Repository navigation
feat(experimentation): hide experimentation UI when the experimentation infra isn't deployed - #8749
Conversation
…on infra isn't deployed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: 🟡 Moderate · up to
|
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
17fb4e27-e64d-4af4-b3e5-fa897ffb18d1
📒 Files selected for processing (9)
frontend/common/hooks/__tests__/useFeatureExperimentFreeze.test.tsfrontend/common/hooks/useFeatureExperimentFreeze.tsfrontend/common/types/responses.tsfrontend/common/utils/utils.tsxfrontend/web/components/modals/create-feature/tabs/FeatureValueTab.tsxfrontend/web/components/navigation/navbars/EnvironmentNavbar.tsxfrontend/web/components/pages/ExperimentDetailPage.tsxfrontend/web/components/pages/ExperimentsPage.tsxfrontend/web/components/pages/environment-settings/EnvironmentSettingsPage.tsx
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #21891 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #21891 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #21891 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #21891 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #21844 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #21844 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #21844 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #21844 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #21842 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #21842 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #21842 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #21842 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Visual Regression20 screenshots compared. See report for details. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
087b9dc8-f4a8-4884-b4b3-e75be10704c3
📒 Files selected for processing (9)
frontend/common/hooks/__tests__/useFeatureExperimentFreeze.test.tsfrontend/common/hooks/__tests__/useHasExperimentationFeature.test.tsfrontend/common/hooks/useFeatureExperimentFreeze.tsfrontend/common/hooks/useHasExperimentationFeature.tsfrontend/web/components/modals/create-feature/tabs/FeatureValueTab.tsxfrontend/web/components/navigation/navbars/EnvironmentNavbar.tsxfrontend/web/components/pages/ExperimentDetailPage.tsxfrontend/web/components/pages/ExperimentsPage.tsxfrontend/web/components/pages/environment-settings/EnvironmentSettingsPage.tsx
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Experimentation UI shows whenever its flag is on, even on installs without the experimentation infra.
useHasExperimentationFeature(flag)hook: the flag andexperimentation_enabledfrom/version/must both be on. Pages wait for/version/before redirecting.experimental_flagsandexperimentation_warehouse_connectiongate.Merge after #8747 is deployed, otherwise SaaS loses the experimentation UI.
How did you test this code?
New
useHasExperimentationFeatureunit tests and updateduseFeatureExperimentFreezetests; lint passes on changed files.