Skip to content

docs(experimentation): List the experimentation values in the Helm chart values table - #8800

Merged
gagantrivedi merged 2 commits into
mainfrom
docs/chart-values-experimentation
Oct 16, 2026
Merged

gagantrivedi merged 2 commits into
mainfrom
docs/chart-values-experimentation

Conversation

@gagantrivedi

@gagantrivedi gagantrivedi commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Changes

Contributes to Flagsmith/flagsmith-charts#616

The Kubernetes guide's Chart Values table had no experimentation values. This adds:

  • experimentation.*: Kafka, ingestion, warehouse delivery, and the warehouse credentials secret
  • ingress.ingestion
  • jobs.experimentationInit

The defaults are taken from the chart's values.yaml. The warehouseCredentialsSecretFromExistingSecret rows depend on Flagsmith/flagsmith-charts#616.

How did you test this code?

Checked each default against charts/flagsmith/values.yaml on chart main, and the warehouse credentials rows against #616.

@gagantrivedi
gagantrivedi requested a review from a team as a code owner October 16, 2026 09:51
@gagantrivedi
gagantrivedi requested review from Holmus and removed request for a team October 16, 2026 09:51
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 16, 2026 10:26am UTC
2 Skipped Deployments
Project Deployment Actions Updated
flagsmith-frontend-preview Ignored Ignored Preview Oct 16, 2026 10:26am UTC
flagsmith-frontend-staging Ignored Ignored Preview Oct 16, 2026 10:26am UTC

Request Review

@github-actions github-actions Bot added the docs Documentation updates label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: aacaa3cb-102e-4c9b-9371-8c7f0f158e0f
📥 Commits

Reviewing files that changed from the base of the PR and between 0c66ae7 and b2201a7.

📒 Files selected for processing: 1
  • docs/docs/deployment-self-hosting/hosting-guides/kubernetes-openshift.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

The Kubernetes and OpenShift hosting guide adds chart-value documentation for event-ingestion Ingress, experimentation and Kafka configuration, credential secrets, event-ingestion and warehouse-delivery settings, and the Kafka topic-creation job. It also documents that warehouse-delivery replicas above the Kafka topic partition count sit idle.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: 🔵 Low · up to b2201

Users following the guide’s warehouse-credentials Secret instructions may find that the current chart does not support those options. The issue is limited to that configuration; the other added entries match the chart, so this is mergeable with the limitation corrected or accepted.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e448a64b-0894-4be8-8676-19637989b549
📥 Commits

Reviewing files that changed from the base of the PR and between a815a96 and 0c66ae7.

📒 Files selected for processing: 1
  • docs/docs/deployment-self-hosting/hosting-guides/kubernetes-openshift.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Comment thread docs/docs/deployment-self-hosting/hosting-guides/kubernetes-openshift.md Outdated
Comment thread docs/docs/deployment-self-hosting/hosting-guides/kubernetes-openshift.md Outdated
@gagantrivedi
gagantrivedi merged commit 1b1adff into main Oct 16, 2026
12 of 13 checks passed
@gagantrivedi
gagantrivedi deleted the docs/chart-values-experimentation branch October 16, 2026 12:03

This branch was successfully deployed

1 active deployment
Preview – docs — b2201a79 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants