Skip to content

ci: Publish images with OCI media types - #8815

Open
germangarces wants to merge 2 commits into
mainfrom
ci/oci-media-types
Open

germangarces wants to merge 2 commits into
mainfrom
ci/oci-media-types

Conversation

@germangarces

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Our images are published with Docker v2 media types. Modern Docker, containerd and Kubernetes all pull OCI images.

  • Push images with OCI media types instead of Docker v2 media types.

Already published tags keep their Docker media types. Only new releases are affected.

How did you test this code?

  1. Let CI build the images on this PR, or run the workflow on main after merge.
  2. Run docker buildx imagetools inspect ghcr.io/flagsmith/flagsmith-private-cloud:<tag>.
  3. Check that MediaType is application/vnd.oci.image.index.v1+json.
  4. Run docker pull on the image for linux/amd64 and linux/arm64 to confirm both still work.

Signed-off-by: germangarces <german.garces@flagsmith.com>
@germangarces
germangarces requested a review from a team as a code owner October 20, 2026 17:17
@germangarces
germangarces requested review from Zaimwa9 and removed request for a team October 20, 2026 17:17
@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 20, 2026 5:18pm UTC
flagsmith-frontend-preview Ignored Ignored Preview Oct 20, 2026 5:18pm UTC
flagsmith-frontend-staging Ignored Ignored Preview Oct 20, 2026 5:18pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f9679b71-a431-41b6-906d-13e714d18778
📥 Commits

Reviewing files that changed from the base of the PR and between b593df0 and 3f13fe2.

📒 Files selected for processing: 1
  • .github/workflows/.reusable-docker-build.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The Docker build step now configures image output with OCI media types.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 3f13f

The image publishing change is ready to merge; no concrete compatibility or publication failure was found.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: germangarces <german.garces@flagsmith.com>
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8815 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8815 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8815 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-8815 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8815 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8815 Finished ✅ Results ✅

@github-actions

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report

@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
❌ private-cloud · depot-ubuntu-latest-arm-16 — run #22605 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  1 minute, 14 seconds
commit  ea591a9
info  📦 Artifacts: View test results and HTML report
🔄 Run: #22605 (attempt 1)

Failed tests

firefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise
firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #22604 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 5 suites
duration  36.7 seconds
commit  c3f2ae3
info  🔄 Run: #22604 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22604 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  37.3 seconds
commit  c3f2ae3
info  🔄 Run: #22604 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22606 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.8 seconds
commit  a2be0e0
info  🔄 Run: #22606 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22607 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.5 seconds
commit  3f13fe2
info  🔄 Run: #22607 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #22606 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  3.9 seconds
commit  a2be0e0
info  🔄 Run: #22606 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #22605 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  32.8 seconds
commit  ea591a9
info  🔄 Run: #22605 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #22607 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  43.8 seconds
commit  3f13fe2
info  🔄 Run: #22607 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #22605 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  37.3 seconds
commit  ea591a9
info  🔄 Run: #22605 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #22606 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.4 seconds
commit  a2be0e0
info  🔄 Run: #22606 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #22606 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  32.2 seconds
commit  a2be0e0
info  🔄 Run: #22606 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #22605 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  31.6 seconds
commit  ea591a9
info  🔄 Run: #22605 (attempt 1)

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (c582d5b) to head (3f13fe2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8815   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files        1683     1683           
  Lines       70275    70275           
=======================================
  Hits        69489    69489           
  Misses        786      786           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

24 screenshots compared. See report for details.
View full report

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant