Skip to content

test(Change requests): Cover versioned, edited and scheduled change requests - #8818

Draft
talissoncosta wants to merge 2 commits into
mainfrom
test/change-request-e2e-coverage
Draft

talissoncosta wants to merge 2 commits into
mainfrom
test/change-request-e2e-coverage

Conversation

@talissoncosta

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Our only change request E2E test covers a value change in a non-versioned environment. The flag dependencies stack (#8715, #8716) changed paths every change request goes through, so this adds three @enterprise tests:

  • Versioned environment, segment override only: the change request page opens the diff on Segment Overrides.
  • Edit from the change request page: the toast says Updated Change Request #<id> and the page shows the edited value.
  • Scheduled for 2099: the page shows it as a scheduled change.

Helpers: createChangeRequest takes the button that opens it and an optional schedule date; new editChangeRequest, updateChangeRequest, enableFeatureVersioning and addSegmentOverrideConfigForSegment (picks the segment by name, as the shared project has others).

Dependency coverage comes in a follow-up.

How did you test this code?

Not run locally: change requests need the private workflows_logic. CI's private cloud E2E job runs them.

…equests

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Oct 21, 2026 2:10pm UTC
flagsmith-frontend-staging Ready Ready Preview Oct 21, 2026 2:10pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 21, 2026 2:10pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…d schedule check

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-preview — efab63d7 Deployed Oct 21, 2026 by vercel[bot]
Preview – flagsmith-frontend-staging — efab63d7 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant