Repository navigation
test(Change requests): Cover versioned, edited and scheduled change requests - #8818
Draft
talissoncosta wants to merge 2 commits into
Draft
talissoncosta wants to merge 2 commits into
talissoncosta wants to merge 2 commits into
Conversation
…equests Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…d schedule check Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Our only change request E2E test covers a value change in a non-versioned environment. The flag dependencies stack (#8715, #8716) changed paths every change request goes through, so this adds three
@enterprisetests:Updated Change Request #<id>and the page shows the edited value.Helpers:
createChangeRequesttakes the button that opens it and an optional schedule date; neweditChangeRequest,updateChangeRequest,enableFeatureVersioningandaddSegmentOverrideConfigForSegment(picks the segment by name, as the shared project has others).Dependency coverage comes in a follow-up.
How did you test this code?
Not run locally: change requests need the private
workflows_logic. CI's private cloud E2E job runs them.