Repository navigation
Conversation
…t` example Generated with [Linear](https://linear.app/flagsmith/agent-session/907914e8-c04c-4f4d-8b1b-ccae84bad4f8) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Generated with [Linear](https://linear.app/flagsmith/agent-session/907914e8-c04c-4f4d-8b1b-ccae84bad4f8) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
emyller
changed the title
api option in the quick start guide's flagsmith.init exampleapi argument in the flagsmith.init example
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes https://linear.app/flagsmith/issue/DOCS-4
Self-hosted and private cloud users following the quick start couldn't tell that they need to point the SDK at their own API. The Connect to the Flagsmith API example now includes a commented-out
apiargument with a one-line note on who should set it. SaaS users can leave it commented out. The text after the example now also mentions that the SDK calls your own API whenapiis set.Review effort: 1/5
How did you test this code?
make buildindocs/succeeds, and the comment appears in the built quick start page.prettier@3.4.2(the version pinned in pre-commit) leaves the changed lines untouched. The file already fails Prettier onmainfor unrelated paragraphs, so I didn't reformat it here.