Repository navigation
Refactor preview sizing and fix PageUp/PageDown - #4723
Draft
DavidGBrett wants to merge 3 commits into
Draft
DavidGBrett wants to merge 3 commits into
DavidGBrett wants to merge 3 commits into
Conversation
DavidGBrett
changed the title
DavidGBrett
force-pushed
the
fix-page-navigation-visible-rows
branch
from
October 25, 2026 22:01
9339e97 to
048246e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Follow-up for #4719
Fixes #4722
This currently contains two related pieces. They can still be split into separate PRs if that makes review easier.
Preview refactor
InternalPreviewVisiblethe authoritative preview state.IsPreviewOnstate and keep standalone preview behavior explicit.PageUp/PageDown fix
Testing
dotnet build Flow.Launcher.Test\Flow.Launcher.Test.csproj --no-restore --nologo