Repository navigation
Skip Vulkan when picking a renderer - #16
Merged
Merged
Conversation
egui-wgpu enables every backend by default, so wgpu creates a Vulkan instance on startup even if it ends up rendering with DX12. On older Intel GPUs (HD 520 / Skylake) the Vulkan driver crashes inside that call, taking Throttle down before the window opens. Limit the backends to DX12 with GL as a fallback. WGPU_BACKEND can still override this. Fixes #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throttle was crashing on startup on older Intel GPUs (HD 520 in #14) because wgpu sets up a Vulkan instance even when it renders with DX12, and that Intel Vulkan driver crashes in the process.
This limits the renderer to DX12, with GL as a fallback. Throttle only draws a 2D UI, so there's no visible difference, and
WGPU_BACKEND=vulkan(set as a user environment variable, because of the admin elevation) still brings Vulkan back for anyone who wants it.Tested on my AMD machine, still works fine. Not tested on Intel HD hardware yet.
Fixes #14