Repository navigation
Conversation
In SMP builds, each core has an idle task at tskIDLE_PRIORITY (one real, the rest passive), so the ready list at that priority always holds at least configNUMBER_OF_CORES tasks. prvIdleTask (tasks.c line 5868) and prvPassiveIdleTask (line 5958) already account for this by checking whether the length of that list is greater than configNUMBER_OF_CORES, but the same check in prvGetExpectedIdleTime (line 4038) was missed and still compares against 1. With more than one core, it always concludes that other idle priority tasks are ready and returns 0, so tickless idle never suppresses ticks. Apply the same comparison there. Single core behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SMP builds, each core has an idle task at tskIDLE_PRIORITY (one real, the rest passive), so the ready list at that priority always holds at least configNUMBER_OF_CORES tasks. prvIdleTask (tasks.c line 5868) and prvPassiveIdleTask (line 5958) already account for this by checking whether the length of that list is greater than configNUMBER_OF_CORES, but the same check in prvGetExpectedIdleTime (line 4038) was missed and still compares against 1. With more than one core, it always concludes that other idle priority tasks are ready and returns 0, so tickless idle never suppresses ticks. Apply the same comparison there. Single core behaviour is unchanged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.