Repository navigation
fix(bash-write): fd-dup and /dev/null targets glued to a closing paren (0.1.116) - #128
Merged
Merged
Conversation
… closing paren `(cmd 2>&1)` read the target as "1)" and raised a false Bash file-write confirm (regression from 0.1.115). The word now ends at `)` only when it is a pure fd dup/close or exactly /dev/null; every other target keeps its previous reading. Adds case-table test and shared guardVerdict helper; records the owner decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 0.1.116 (version bump + CHANGELOG in a separate commit).
(cmd 2>&1),(cmd >&2),(cmd 2>&-)or(cmd >/dev/null)— an fd duplication/close or /dev/null target glued to a closing parenthesis was read as a file named1)(regression from 0.1.115). Every other redirect target keeps its previous verdict.Changes
src/policy/guards/bash-write-redirect-op.tstest/bash-write-fd-dup-paren.test.ts,test/helpers/redir-corpus.tsdocs/decisions.md,CHANGELOG.md,package.jsonTest plan
tsc0 errorsBreaking changes
None