Repository navigation
fix(web-ui): add branch picker refresh and preserve selected styling - #3290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composer branch picker has no refresh action, and hovering or using keyboard navigation overrides the current branch's selected background. Add a refresh button beside search and preserve the selected background across hover, press, and virtual keyboard focus.
Type and Areas
Type: bug fix / UI/UX
Areas: Web UI, shared design system
Motivation / Impact
Verification
pnpm --dir src/web-ui run test:run src/tools/git/components/BranchQuickSwitch.test.tsx src/tools/git/services/GitService.test.ts src/shared/ui/MenuComposition.contract.test.ts— 28 tests passed.node --test design-system/packages/ui/tests/listbox.test.mjs— 4 tests passed.pnpm --dir src/web-ui run icons:check— passed.pnpm --dir src/web-ui exec vitest run src/infrastructure/design-system/IconUsageIntegration.test.tsx src/app/startup/startupPreload.test.ts— 21 tests passed.pnpm run check:web— passed, including TypeScript, Appearance contracts, theme colors, and visual governance.pnpm run i18n:audit— passed with no warnings.pnpm run motion:audit— inventory reviewed; no new animation was introduced.git diff --check— passed.Reviewer Notes
AI-assisted implementation, tested with focused unit/DOM tests and repository checks. No live GUI before/after capture was performed, so screenshots are unavailable. Tests exercise workspace scope forwarding and stale response handling with mocks; remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised end to end.
The Listbox fix lowers transient interaction selector specificity while keeping forced-colors overrides intact. English, Simplified Chinese, and Traditional Chinese copy is updated. No persisted or wire-format changes are required.
Checklist