Repository navigation
feat: Adding flow statistics for arbitrary mesh cell element sets - #4005
Merged
Merged
Conversation
victorapm
self-requested a review
August 13, 2026 17:00
OmarDuran
reviewed
Aug 28, 2026
OmarDuran
reviewed
Aug 28, 2026
MelReyCG
added
the
ci: run device builds
tjb-ltk
approved these changes
Sep 4, 2026
Contributor
|
@jhuang2601 and/or @joshua-white could you take a look as code owners? |
jhuang2601
approved these changes
Sep 25, 2026
| auto const * const subRegionSetWrapper = subRegion.sets().getWrapperPointer< SetType >( setName ); | ||
| if( subRegionSetWrapper != nullptr ) | ||
| { | ||
| if( subRegionSetWrapper->reference().empty() ) |
Contributor
There was a problem hiding this comment.
Suggested change
| if( subRegionSetWrapper->reference().empty() ) | |
| if( !subRegionSetWrapper->reference().empty() ) |
A requested set should be considered valid if at least one rank reports it as found and non-empty, right?
joshua-white
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at extending the flow statistics components by introducing an optional
setNamesparameter toSinglePhaseStatisticsandCompositionalMultiphaseStatistics, allowing users to obtain statistics computation from arbitrary mesh element sets instead of being forced to process solver regions.Sets can already be defined with
Geometryobjects likeBox.Multiple set can be provided for a given statistics component, and in that case, statistics over all provided sets are also logged. To support intersecting sets and give valid statistics, they are computed on a compound set (union of all selected set).
Here is an example:
The infrastructure proposed here can be re-used for new statistics components which would process cell elements, and is implemented at the
StatisticsAggregatorBaselevel, introduced in the PR #3836 .The parameter has been used in the
simpleCo2InjTutorialexample to test that functionnality.