Repository navigation
ci: add MacOS build - #4152
Open
victorapm wants to merge 28 commits into
Open
ci: add MacOS build#4152victorapm wants to merge 28 commits into
victorapm wants to merge 28 commits into
Conversation
victorapm
added
flag: ready for review
flag: requires updated TPL(s)
victorapm
added
the
ci: run integrated tests
victorapm
requested review from
dkachuma,
herve-gross and
jhuang2601
as code owners
September 24, 2026 16:29
victorapm
added
the
ci: run code coverage
victorapm
added
the
ci: run device builds
…o the source tree.
Contributor
Author
|
@rrsettgast @joshua-white @OmarDuran @tjb-ltk and any other mac users: this is ready for review |
Contributor
Author
|
pinging @MelReyCG , @OmarDuran , @bd713 , @corbett5 , @dkachuma , @herve-gross , @jhuang2601 for a code owner review 🙏 |
herve-gross
approved these changes
Oct 16, 2026
jhuang2601
approved these changes
Oct 16, 2026
MelReyCG
approved these changes
Oct 20, 2026
MelReyCG
left a comment
MelReyCG
left a comment
Contributor
There was a problem hiding this comment.
Looks alright to me, just a few minor suggestions:
-
No unit-test for this system? Is it for performance or are there some that do not pass?
-
maybe consider to add plain script files rathen than directly writing them in the
run:Load TPL image&Build GEOSare quite long, andLoad TPL imageeven have a subscript (scripts/macos_loadTPL.sh/scripts/macos_build.sh?).
bd713
approved these changes
Oct 20, 2026
Contributor
Author
joshua-white
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on GEOS-DEV/thirdPartyLibs#370
Fixes #3272