Repository navigation
Conversation
dkachuma
added
type: bug
dkachuma
marked this pull request as ready for review
October 13, 2026 15:56
dkachuma
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A regression test is needed for zero salinity with non-default compressibility.
1 open finding
What changed in this PR
Propagates user-configured water compressibility into pure-water Phillips density calculations.
Changes:
- Passes configured compressibility into the pure-water calculation.
- Removes the hard-coded compressibility value.
| File | Description |
|---|---|
PhillipsBrineDensity.cpp |
Uses supplied compressibility for zero-salinity density. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jhuang2601
approved these changes
Oct 13, 2026
dkachuma
requested review from
OmarDuran,
cssherman and
rrsettgast
as code owners
October 16, 2026 12:06
dkachuma
added
flag: requires rebaseline
joshua-white
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates the user supplied water compressibility to the actual computation. Currently this is still using the hard-coded value. This applies to pure water density calculations i.e. when salinity is zero.
Add a new pvt driver test to cover the zero salinity path.