Repository navigation
Bump version to 5.4.2 - #59
Merged
Merged
Conversation
release.py prepare bumps GA_VERSION_STR, updates CHANGELOG.md and opens the release PR; release.py publish tags the merged PR and triggers the Create Release workflow via gh_create_release.py. The workflow's tag step now reuses an existing tag when it points at the commit being built, since release.py pushes the tag first.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 58.36% 58.79% +0.42%
==========================================
Files 23 23
Lines 3060 3060
Branches 1512 1512
==========================================
+ Hits 1786 1799 +13
+ Misses 951 939 -12
+ Partials 323 322 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Dispatch errors are printed without a nonzero exit, so publishing can appear successful after pushing the release tag even though GitHub rejected the release build dispatch.
1 open issue
What changed in this PR
Prepares the C++ SDK for version 5.4.2 and adds tooling to prepare release PRs and publish merged releases.
Changes:
- Updates the SDK version and records Linux and Windows fixes in the changelog.
- Adds
release.pywithprepareandpublishcommands. - Allows the release workflow to reuse a tag when it points to the commit being built.
| File | Description |
|---|---|
source/gameanalytics/GACommon.h |
Updates the SDK version to cpp 5.4.2. |
release.py |
Adds release preparation, tagging, and workflow dispatch. |
CHANGELOG.md |
Adds the 5.4.2 release notes. |
.github/workflows/create_release.yml |
Validates and reuses existing release tags. |
Review effort: Balanced
| if run("git", "rev-parse", f"origin/{BASE_BRANCH}") != commit: | ||
| sys.exit(f"origin/{BASE_BRANCH} has moved past {tag}, so the release build would not match the tag. " | ||
| f"Workflow not triggered.") | ||
| trigger_workflow(tag) |
Gogoshika-ga
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump ahead of the
v5.4.2release.GA_VERSION_STR→cpp 5.4.2(source/gameanalytics/GACommon.h)CHANGELOG.md:## 5.4.2release.py: new release script (prepare/publish).github/workflows/create_release.yml: the tag step reuses an existing tag if it points at the commit being builtFixed
Once merged, tag and release with
python release.py publish 5.4.2.