Repository navigation
bugfix(gui): Checkboxes and slider blocks no longer draw offset or notched - #651
Closed
tintinhamans wants to merge 10 commits into
Closed
tintinhamans wants to merge 10 commits into
tintinhamans wants to merge 10 commits into
Conversation
…m::openArchiveFile() (TheSuperHackers#3376) (cherry picked from commit 86f2cab)
(cherry picked from commit 5db4f75)
…leSystem, Win32LocalFileSystem (TheSuperHackers#3374) (cherry picked from commit 3f3ed9f)
…ile::getFileInfo(), StdBIGFile::getFileInfo() (TheSuperHackers#3415) (cherry picked from commit b805c12)
…File (TheSuperHackers#3505) Both classes are identical apart from their name and contain no platform specific code. Nothing in them depends on the BIG format either: they open a file from an offset and a size inside the archive file. ArchiveFile takes over their functions and is no longer an abstract class. (cherry picked from commit 52a777a)
…ystem into BIGFileSystem (TheSuperHackers#3505) Both classes are identical apart from their name and go through the local file system for all file access. The one class that remains sits next to ArchiveFileSystem in Core/GameEngine. (cherry picked from commit e4b4d1e)
…e loadBigFilesFromDirectory (TheSuperHackers#3505) loadMods refers to BIG files, which nothing else in ArchiveFileSystem does. It becomes a virtual function that BIGFileSystem implements. loadBigFilesFromDirectory is renamed to loadArchiveFilesFromDirectory, because the base class is not tied to one archive format. (cherry picked from commit f299561)
tintinhamans
force-pushed
the
arctic/go/fix/checkbox-slider-art
branch
from
October 24, 2026 22:07
14451c9 to
9244531
Compare
tintinhamans
force-pushed
the
arctic/go/fix/checkbox-slider-art
branch
from
October 24, 2026 23:48
9244531 to
8c799ff
Compare
tintinhamans
marked this pull request as draft
October 24, 2026 23:48
Author
|
Folded into #655. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #648.
Shell checkboxes draw about 1 source pixel up and left of their row, and filled slider blocks have a 2x2 transparent notch. This redefines the affected images in
ZZ_GeneralsOnline_CheckboxSliderArt.INIwith a fixed 16x16GeneralsOnline_CheckboxSliderArt.tga.Data only, shipped in
GeneralsOnline_Core.big.Tested at 2560x1440: checkbox offset -2.5 px to 0.0, notched slider blocks 91 of 91 to 0.