Repository navigation
refactor(lobby): centralize membership commands and state ownership - #71
Open
tintinhamans wants to merge 7 commits into
Open
tintinhamans wants to merge 7 commits into
tintinhamans wants to merge 7 commits into
Conversation
This was referenced Oct 16, 2026
tintinhamans
force-pushed
the
arctic/refactor/lobby-membership-boundary
branch
from
October 29, 2026 04:59
21f3585 to
f6f8f58
Compare
tintinhamans
force-pushed
the
arctic/refactor/lobby-membership-boundary
branch
from
October 29, 2026 05:13
f6f8f58 to
d11d2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves lobby join, leave and kick handling out of the controller and into LobbyManager. Membership changes for each player are coordinated across lobbies, and kick permissions are checked alongside removal under the same lock. Existing endpoints and response formats stay the same.
Builds on #78, so its commits stay in the diff until it lands. The lobby code it touches logs through
ILoggerto match.