Repository navigation
Storage: exclude_from_backup/1 reports :unsupported on an older iOS native build - #210
Merged
Merged
Conversation
…ative build that predates it, not a false :ok (release gate for 0.9.21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.9.21 release gate (reviewer subagent; Codex at its usage limit) found that
exclude_from_backup/1returned:okwhen new BEAMs ran on an iOS native build that predates the NIF (the Erlang stub raises:not_loaded), so the path stayed in iCloud backup while the call reported success.Now: a missing NIF answers by platform (
nif.platform/0, guarded): iOS gets{:error, :unsupported}; Android and the host keep the no-op:ok(nothing is backed up there). The NIF module is injectable (nif \\\\ :mob_nif), asMob.RenderStats.native_call/3does, so the old-iOS case is tested with stub modules. The new test fails on the previous code (it got:ok).CHANGELOG [Unreleased] and the guide say the iOS half needs
mix mob.deploy --native.Tracked in bezalel-lac.3 (Linear's free-tier issue limit is reached).