Repository navigation
Docs: :scroll's axis prop in the components guide (#212) - #213
Merged
Merged
Conversation
…rop table, with an example; one spelling ("horizontal"); a test that both forms reach the renderer as "horizontal" (#212)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212.
Horizontal scrolling worked on both platforms (iOS reads
axisin mob_nif.m and branches on"horizontal"in MobRootView.swift; Android's bridge comparesnode.props["axis"] == "horizontal"), but the:scrollreference called it "A vertically scrolling container" and its prop table omittedaxisandshow_indicator. It was only in styling.md's mapping table, the surface matrix, and in passing in the anchor section.axisandshow_indicatorin the table,lazy/anchormarked vertical-only, a horizontal example, and a note that atom and string both work.axis: :horizontaland"horizontal"both reach the native tree as"horizontal"on iOS and Android (the contract both renderers branch on).Docs-only plus a contract test, so no adversarial review (mechanical per AGENTS.md). Reaches users with the next patch release (guides ship in the Hex package).