Fix a leak when gmtlib_read_table deletes an empty segment - #9237
Merged
Merged
Conversation
The row == 0 deletion inside the read loop freed the segment struct but not its hidden struct, allocated together in gmt_get_segment, nor its header and label. The deletion after the loop, for a last empty segment, already frees hidden; that segment never gets a header. The header can be set here because segment_header still holds the previous file's last segment header when several files are read. Tested with (a -DMEMDEBUG build): printf '30 45\n120 60\n' | GMT_TRACK_MEMORY=on gmt convert -i0:2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Esteban82
marked this pull request as ready for review
September 30, 2026 00:54
joa-quim
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude flagged this leak: the
row == 0deletion inside the read loop frees a segment's struct but not itshiddenstruct, both allocated together ingmt_get_segment. The equivalent deletion after the loop, for a last empty segment (gmt_io.c:8526), already frees both -- this fix does the same here, and also frees the segment'sheader/label, which it can inherit from the previous file's last segment header when several files are read.Tested with:
(needs a build with
-DMEMDEBUG, GMT's own leak tracker;cmake/ConfigUserAdvanced.cmakehas the toggle)Assisted-by: Claude Opus 5.5; PR text first drafted with Claude Sonnet 5.
🤖 Generated with Claude Code