Fix pssolar tests failing on last-command exit status - #9239
Merged
Merged
Conversation
The last line of each script was 'cmd && echo ... >> fail', where cmd is expected to return nonzero, so the script exited 1 and gmtest's ERR trap flagged the test as failed even with an empty fail file. Use an if instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joa-quim
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pssolar_tz.shandpssolar_missing_plusd.shended withcmd && echo ... >> failwherecmdis expected to fail, so the script exited 1 and gmtest's ERR trap marked them failed with an emptyfailfile (seen on master and in #9235). Useifinstead.This can be checked by seeing both tests pass in CI.
Model: Claude Sonnet 5.5