Skip to content

test: use Roslyn framework alongside focused unit tests - #56

Closed
ScottishTapWater wants to merge 16 commits into
mainfrom
refactor/roslyn-testing-framework
Closed

ScottishTapWater wants to merge 16 commits into
mainfrom
refactor/roslyn-testing-framework

Conversation

@ScottishTapWater

@ScottishTapWater ScottishTapWater commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Use Microsoft.CodeAnalysis.Testing for analyser, code-fix and generator integration tests. Keep focused unit tests for plans, symbol readers, discovery and emitters, with exhaustive data matrices at those boundaries.

Retain semantic generator tests for inference, overload selection, nullable lifting, metadata and discovery across dependent operations. Execute their resulting compilations in memory to check numerical results alongside binding. Embedded C# uses formatted multiline raw strings.

Three fixtures prepare packages for archive inspection, delivery and A/B/C interoperability. Each packs its inputs once. Consumer projects retain separate feeds and caches. The A/B/C test checks shared type identity and downstream arithmetic across two independently packed producers.

The diff is confined to the two test projects and solution ordering. Production code and CI are unchanged. The test dependency Microsoft.VisualStudio.Validation uses recognised MIT licence metadata.

Validation:

  • All 1,551 tests passed with none skipped: 1,006 Roslyn cases, 58 package cases and 487 runtime/extension cases.
  • Release build passed with zero warnings or errors; formatting verification passed.
  • Isolated mutations confirmed detection of a missing catalogue helper, integer division in a fractional prefix, broken intermediate discovery and incorrect numerical arithmetic with unchanged result types.
  • A matched local timing trial shows no speed improvement. Coverage differs substantially across the compared suites.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Licence compliance passed

The current ORT run passed.

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The reviewed changes appear safe to merge, with no new actionable issues established.

Summary

Moves compiler tests to Microsoft.CodeAnalysis.Testing while keeping focused tests for discovery, plans, readers, and emitters.

  • Analyzer and code-fix tests use Roslyn’s test framework to check compiler results.
  • Generator tests separate discovery and emission from compilation and execution checks.
  • Runtime and unit-provider tests check arithmetic, conversions, and generated unit factories.
  • Package tests restore isolated consumer projects from locally packed library archives.

Reviews (7) · Last reviewed commit: "test: restore focused Roslyn unit layers..." · Reviewed by Greptile

@ScottishTapWater ScottishTapWater changed the title Replace custom Roslyn test infrastructure with Microsoft.CodeAnalysis.Testing test: replace custom Roslyn test infrastructure with Microsoft.CodeAnalysis.Testing Nov 13, 2026
@ScottishTapWater

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T15:07:02.017233Z 5595f54 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 5595f540e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ScottishTapWater ScottishTapWater changed the title test: replace custom Roslyn test infrastructure with Microsoft.CodeAnalysis.Testing test: use Roslyn framework alongside focused unit tests Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant