Repository navigation
test: migrate Roslyn integration tests to Microsoft testing framework - #57
Conversation
[Low impact] The PR appears safe to merge, with no new findings or outstanding previous findings.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The Roslyn integration tests use bespoke compilation, diagnostic, and code-action plumbing. Move analyser, code-fix, and single-run generator integration cases to Microsoft.CodeAnalysis.Testing while preserving focused component tests and driver-reuse scenarios. Production code is unchanged.
Separate package fixtures by purpose, retaining the original packaged A/B/C, temperature, and all-unit scenarios with fresh consumer workspaces. Add Fix All and fractional-prefix regression coverage. Pin test-only System.Security.Cryptography.Pkcs to 9.0.21 and Microsoft.VisualStudio.Validation to 17.13.22 to resolve the vulnerability and licence findings.
Generated-source snapshots are skipped in behavioural integration cases; diagnostic verification remains enabled. Two collision cases retain their original generator-diagnostic-only scope.
Validation on Linux:
Matched local runs of the same 532 Roslyn cases took 122.56 seconds before and 154.68 seconds after, approximately 26% longer. These are individual process timings with no concurrent builds or tests, not a statistical benchmark.