Skip to content

test: migrate Roslyn integration tests to Microsoft testing framework - #57

Merged
ScottishTapWater merged 2 commits into
mainfrom
refactor/roslyn-framework-incremental
Nov 14, 2026
Merged

ScottishTapWater merged 2 commits into
mainfrom
refactor/roslyn-framework-incremental

Conversation

@ScottishTapWater

Copy link
Copy Markdown
Contributor

The Roslyn integration tests use bespoke compilation, diagnostic, and code-action plumbing. Move analyser, code-fix, and single-run generator integration cases to Microsoft.CodeAnalysis.Testing while preserving focused component tests and driver-reuse scenarios. Production code is unchanged.

Separate package fixtures by purpose, retaining the original packaged A/B/C, temperature, and all-unit scenarios with fresh consumer workspaces. Add Fix All and fractional-prefix regression coverage. Pin test-only System.Security.Cryptography.Pkcs to 9.0.21 and Microsoft.VisualStudio.Validation to 17.13.22 to resolve the vulnerability and licence findings.

Generated-source snapshots are skipped in behavioural integration cases; diagnostic verification remains enabled. Two collision cases retain their original generator-diagnostic-only scope.

Validation on Linux:

  • Full solution: 1,037 passed. After the final dependency pin, all 536 Roslyn tests passed again; a subsequent run also passed all 14 package integration tests.
  • Deliberately introducing integer division and an extra code-fix action caused all seven targeted checks to fail. Both temporary changes were restored.
  • Release build, changed-file formatting verification, package and symbol checks, and diff checks passed. NuGet reported no vulnerable test-project packages; the validation package declares MIT.
  • Existing System.Composition assembly-version and MSBuild dependency-constraint warnings remain. Windows validation is left to CI.

Matched local runs of the same 532 Roslyn cases took 122.56 seconds before and 154.68 seconds after, approximately 26% longer. These are individual process timings with no concurrent builds or tests, not a statistical benchmark.

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with no new findings or outstanding previous findings.

Summary

Moves Roslyn integration tests to Microsoft.CodeAnalysis.Testing without changing production code.

  • Analyzer and code-fix tests use Microsoft's testing framework.
  • Single-run generator tests use a shared Microsoft test harness.
  • Package tests use shared fixtures and clean consumer workspaces.

No changes were supplied since the previous review, and no previous findings were provided. The full-PR rule check found no violations.

Reviews (2) · Last reviewed commit: "ci: rerun PR checks with corrected title" · Reviewed by Greptile

@ScottishTapWater ScottishTapWater changed the title Migrate Roslyn integration tests to Microsoft testing framework test: migrate Roslyn integration tests to Microsoft testing framework Nov 14, 2026
@ScottishTapWater

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T22:37:57.051614Z 05e15e9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 05e15e93ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ScottishTapWater
ScottishTapWater merged commit fbf679e into main Nov 14, 2026
6 checks passed
@ScottishTapWater
ScottishTapWater deleted the refactor/roslyn-framework-incremental branch November 14, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant