-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(secretmanager): Add Cloud SQL managed-rotation samples #14562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suvidha-malaviya
wants to merge
4
commits into
GoogleCloudPlatform:main
Choose a base branch
from
suvidha-malaviya:cloudsql-managed-rotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8befcf3
feat(secretmanager): add Cloud SQL managed-rotation samples
suvidha-malaviya e18be75
feat(secretmanager): added few test case
suvidha-malaviya 6f33fd6
feat(secretmanager): update test file
suvidha-malaviya d0ff4e2
feat(secretmanager): Add Cloud SQL managed-rotation samples
suvidha-malaviya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| """ | ||
| command line application and sample code for creating a new secret with a | ||
| secret type restriction. | ||
| """ | ||
|
|
||
| # [START secretmanager_create_secret_with_type] | ||
| import argparse | ||
|
|
||
| # Import the Secret Manager client library. | ||
| from google.cloud import secretmanager | ||
|
|
||
|
|
||
| def create_secret_with_type( | ||
| project_id: str, | ||
| secret_id: str, | ||
| secret_type: secretmanager.Secret.SecretType, | ||
| ) -> secretmanager.Secret: | ||
| """ | ||
| Create a new secret with the given secret type restriction (e.g. | ||
| ACCESS_KEY, CERTIFICATE, OTHER_DB_CREDENTIALS, or OTHER -- use | ||
| CLOUD_SQL_DB_CREDENTIALS only for a regional secret that will go | ||
| through enable_regional_secret_managed_rotation; see the | ||
| regional_samples directory). Unlike CLOUD_SQL_DB_CREDENTIALS, these | ||
| other secret types are plain metadata tags: they don't require any | ||
| additional credentials payload at creation time. | ||
| """ | ||
|
|
||
| # Create the Secret Manager client. | ||
| client = secretmanager.SecretManagerServiceClient() | ||
|
|
||
| # Build the resource name of the parent project. | ||
| parent = f"projects/{project_id}" | ||
|
|
||
| # Create the secret, with the given secret type restriction. | ||
| response = client.create_secret( | ||
| request={ | ||
| "parent": parent, | ||
| "secret_id": secret_id, | ||
| "secret": { | ||
| "replication": {"automatic": {}}, | ||
| "secret_type": secret_type, | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| # Print the new secret name. | ||
| print(f"Created secret with secret type: {response.name}") | ||
|
|
||
| return response | ||
|
|
||
|
|
||
| # [END secretmanager_create_secret_with_type] | ||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser( | ||
| description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter | ||
| ) | ||
| parser.add_argument("project_id", help="id of the GCP project") | ||
| parser.add_argument("secret_id", help="id of the secret to create") | ||
| parser.add_argument( | ||
| "secret_type", | ||
| choices=[t.name for t in secretmanager.Secret.SecretType if t.value != 0], | ||
| help="secret type restriction to apply", | ||
| ) | ||
| args = parser.parse_args() | ||
|
|
||
| create_secret_with_type( | ||
| args.project_id, | ||
| args.secret_id, | ||
| secretmanager.Secret.SecretType[args.secret_type], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| """ | ||
| command line application and sample code for getting the secret type of a | ||
| secret. | ||
| """ | ||
|
|
||
| # [START secretmanager_get_secret_type] | ||
| import argparse | ||
|
|
||
| # Import the Secret Manager client library. | ||
| from google.cloud import secretmanager | ||
|
|
||
|
|
||
| def get_secret_type(project_id: str, secret_id: str) -> secretmanager.Secret: | ||
| """ | ||
| Get and print the secret type (e.g. CLOUD_SQL_DB_CREDENTIALS, | ||
| ACCESS_KEY, CERTIFICATE, OTHER_DB_CREDENTIALS, OTHER, or | ||
| SECRET_TYPE_UNSPECIFIED for a secret with no type restriction) of the | ||
| given secret. | ||
| """ | ||
|
|
||
| # Create the Secret Manager client. | ||
| client = secretmanager.SecretManagerServiceClient() | ||
|
|
||
| # Build the resource name of the secret. | ||
| name = client.secret_path(project_id, secret_id) | ||
|
|
||
| # Get the secret. | ||
| response = client.get_secret(request={"name": name}) | ||
|
|
||
| print(f"Found secret {response.name} with secret type {response.secret_type.name}") | ||
|
|
||
| return response | ||
|
|
||
|
|
||
| # [END secretmanager_get_secret_type] | ||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser( | ||
| description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter | ||
| ) | ||
| parser.add_argument("project_id", help="id of the GCP project") | ||
| parser.add_argument("secret_id", help="id of the secret to get the type of") | ||
| args = parser.parse_args() | ||
|
|
||
| get_secret_type(args.project_id, args.secret_id) |
92 changes: 92 additions & 0 deletions
92
secretmanager/snippets/regional_samples/create_regional_secret_with_cloud_sql_credentials.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| """ | ||
| command line application and sample code for creating a new secret that is | ||
| eligible for Cloud SQL managed rotation. | ||
| """ | ||
|
|
||
| # [START secretmanager_create_regional_secret_with_cloud_sql_credentials] | ||
| import argparse | ||
|
|
||
| # Import the Secret Manager client library. | ||
| from google.cloud import secretmanager_v1 | ||
|
|
||
|
|
||
| def create_regional_secret_with_cloud_sql_credentials( | ||
| project_id: str, | ||
| location_id: str, | ||
| secret_id: str, | ||
| ) -> secretmanager_v1.Secret: | ||
| """ | ||
| Create a new secret with the Cloud SQL DB credentials secret type. This | ||
| type is required to enable Secret Manager's automatic rotation of Cloud | ||
| SQL passwords. It can only be set when the secret is created, and the | ||
| secret's location must match the region of the target Cloud SQL | ||
| instance. | ||
| """ | ||
|
|
||
| # Endpoint to call the regional Secret Manager API. | ||
| api_endpoint = f"secretmanager.{location_id}.rep.googleapis.com" | ||
|
|
||
| # Create the Secret Manager client. | ||
| client = secretmanager_v1.SecretManagerServiceClient( | ||
| client_options={"api_endpoint": api_endpoint}, | ||
| ) | ||
|
|
||
| # Build the resource name of the parent project. | ||
| parent = f"projects/{project_id}/locations/{location_id}" | ||
|
|
||
| # Create the secret. | ||
| response = client.create_secret( | ||
| request={ | ||
| "parent": parent, | ||
| "secret_id": secret_id, | ||
| "secret": { | ||
| "secret_type": secretmanager_v1.Secret.SecretType.CLOUD_SQL_DB_CREDENTIALS, | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| # Print the new secret name. | ||
| print(f"Created secret: {response.name}") | ||
|
|
||
| # This built-in identity is what you grant Cloud SQL IAM permissions to, | ||
| # so that Secret Manager can rotate the database password on its behalf. | ||
| print( | ||
| "Grant this identity Cloud SQL IAM permissions to enable rotation: " | ||
| f"{response.policy_member.iam_policy_uid_principal}" | ||
| ) | ||
|
|
||
| return response | ||
|
|
||
|
|
||
| # [END secretmanager_create_regional_secret_with_cloud_sql_credentials] | ||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser( | ||
| description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter | ||
| ) | ||
| parser.add_argument("project_id", help="id of the GCP project") | ||
| parser.add_argument( | ||
| "location_id", | ||
| help="id of the location where secret is to be created; must match " | ||
| "the Cloud SQL instance's region", | ||
| ) | ||
| parser.add_argument("secret_id", help="id of the secret to create") | ||
| args = parser.parse_args() | ||
|
|
||
| create_regional_secret_with_cloud_sql_credentials( | ||
| args.project_id, args.location_id, args.secret_id | ||
| ) |
105 changes: 105 additions & 0 deletions
105
secretmanager/snippets/regional_samples/enable_regional_secret_managed_rotation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| """ | ||
| command line application and sample code for enabling managed rotation of | ||
| a Cloud SQL DB credentials secret. | ||
| """ | ||
|
|
||
| # [START secretmanager_enable_regional_secret_managed_rotation] | ||
| import argparse | ||
|
|
||
| # Import the Secret Manager client library. | ||
| from google.cloud import secretmanager_v1 | ||
|
|
||
|
|
||
| def enable_regional_secret_managed_rotation( | ||
| project_id: str, | ||
| location_id: str, | ||
| secret_id: str, | ||
| instance_id: str, | ||
| username: str, | ||
| ) -> secretmanager_v1.SecretVersion: | ||
| """ | ||
| Enable managed rotation for a Cloud SQL DB credentials secret. This | ||
| links the secret to a Cloud SQL instance and database user, and can | ||
| only be called once per secret. It adds the secret's first version and | ||
| sets the matching password on the Cloud SQL user, taking the place of | ||
| a manually added secret version, which this secret type doesn't | ||
| support. Afterwards, use rotate_regional_secret.py to trigger further | ||
| rotations. | ||
|
|
||
| instance_id is the bare Cloud SQL instance ID (e.g. "my-instance") -- | ||
| not a connection name. Neither the project nor the region should be | ||
| included: passing "PROJECT_ID:INSTANCE_ID" (as gcloud's own | ||
| `enable-managed-rotation --help` examples misleadingly show) or the | ||
| full "PROJECT_ID:LOCATION_ID:INSTANCE_ID" connection name both fail -- | ||
| the service already knows the project from the secret's own path, and | ||
| prepends it internally, so a qualified value ends up double-prefixed. | ||
| """ | ||
|
|
||
| # Endpoint to call the regional Secret Manager API. | ||
| api_endpoint = f"secretmanager.{location_id}.rep.googleapis.com" | ||
|
|
||
| # Create the Secret Manager client. | ||
| client = secretmanager_v1.SecretManagerServiceClient( | ||
| client_options={"api_endpoint": api_endpoint}, | ||
| ) | ||
|
|
||
| # Build the resource name of the secret. | ||
| parent = f"projects/{project_id}/locations/{location_id}/secrets/{secret_id}" | ||
|
|
||
| # Enable managed rotation. Leaving password unset lets Secret Manager | ||
| # generate a secure password itself. | ||
| response = client.enable_managed_rotation( | ||
| request={ | ||
| "parent": parent, | ||
| "cloud_sql_single_user_credentials": { | ||
| "instance_id": instance_id, | ||
| "username": username, | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| print(f"Enabled managed rotation, created secret version: {response.name}") | ||
|
|
||
| return response | ||
|
|
||
|
|
||
| # [END secretmanager_enable_regional_secret_managed_rotation] | ||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser( | ||
| description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter | ||
| ) | ||
| parser.add_argument("project_id", help="id of the GCP project") | ||
| parser.add_argument("location_id", help="id of location where secret is stored") | ||
| parser.add_argument( | ||
| "secret_id", | ||
| help="id of the Cloud SQL DB credentials secret to enable rotation on", | ||
| ) | ||
| parser.add_argument( | ||
| "instance_id", | ||
| help="bare id of the Cloud SQL instance (no project or region prefix)", | ||
| ) | ||
| parser.add_argument("username", help="username of the Cloud SQL database user") | ||
| args = parser.parse_args() | ||
|
|
||
| enable_regional_secret_managed_rotation( | ||
| args.project_id, | ||
| args.location_id, | ||
| args.secret_id, | ||
| args.instance_id, | ||
| args.username, | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
EnableManagedRotationRequest, the field to specify the secret's resource name isname, notparent. Usingparentas the key in the request dictionary will cause aValueErrorat runtime because the field does not exist on the request message.Please update the request dictionary key to
name(and consider renaming the local variableparenttonamefor clarity).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against the installed SDK — both
enable_managed_rotationandrotate_secretonly define a parent field (no name), so parent is correct here.