Skip to content

Recheck the transactionLogAbortMarkers docs when harper#3928 merges #782

Open

Description

@kriszyp

Deferred from the review of Document storage.rocks.transactionLogAbortMarkers and its 5.4 default (#780), which documents harper#3928 (open, milestone v5.4).

Two nits were accepted rather than fixed in #780:

  1. Recheck the documented default and off-values when harper#3928 merges. The docs say the setting defaults to true and that only false, 0, no or off turn it off. That matches harper#3928's head c8dfa03 (resources/transactionLogAbortMarkers.ts), not current harper main, which turns markers on only for === true. Document storage.rocks.transactionLogAbortMarkers and its 5.4 default #780 carries Depends-on: harper#3928, so it cannot merge first. But if the core PR changes its default, parsing, the 40-conflict cap or the deadline before it merges, the entry in reference/database/storage-tuning.md (and the matching sentences in reference/configuration/options.md and release-notes/v5-lincoln/5.4.md) need the same change.
  2. The conflict deadline for internal deploy writes is not documented. The docs say a conflicting write fails with a 503 once it has been retrying longer than storage.maxTransactionQueueTime. The real deadline is the larger of that and a transaction's own timeoutBudget. Today only Harper's component-deploy recorder sets that budget (components/deploymentRecorder.ts), so client requests never see it. Decide whether it is worth a sentence. The default answer is no, because the brief said to leave out internal retry mechanics.

Close this once harper#3928 has merged and item 1 is confirmed (or fixed in a follow-up), and item 2 is decided.

Review-Deferral: a69043af6e3feeee severity=nit category=documentation

Review-Deferral: 3169e1b09af269e1 severity=nit category=documentation

🤖 Generated by Claude Opus 5.5 with Claude Code; posted via @kriszyp.

Activity

  1. added this to the v5.4 milestone on Nov 2, 2026
  2. added theissue type on Nov 2, 2026
  3. kriszyp commented on Nov 2, 2026

    @kriszyp
    MemberAuthor

    #780 now also documents storage.rocks.transactionLogWriteIntents (default false), in reference/database/storage-tuning.md, reference/configuration/options.md, the three full-restart passages and the 5.4 release note. The setting is not yet on harper#3928's head (1564a87). When harper#3928 merges, also confirm that the merged code has storage.rocks.transactionLogWriteIntents with default false and the same full-restart rule.

    🤖 Generated by Claude Opus 5.5; posted via @kriszyp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    P3

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions