Skip to content

Explain MCP subscription expiry and renewal after credential rotation - #798

Closed
kylebernhardy wants to merge 15 commits into
mainfrom
codex/mcp-subscription-credential-expiry
Closed

kylebernhardy wants to merge 15 commits into
mainfrom
codex/mcp-subscription-credential-expiry

Conversation

@kylebernhardy

@kylebernhardy kylebernhardy commented Nov 4, 2026 •

Copy link
Copy Markdown
Member
Animated felt Kyle as a Winter Soldier-inspired superhero, with Parker and Kato on an autumn rooftop, guiding a glowing cyan thread

📝 Summary

Document when MCP resource subscriptions expire and how clients renew them. Companion to Make MCP resource subscriptions reliable across HTTP workers, targeting core v5.4.

Merge dependency: keep this PR in draft until Fix scoped MCP reconnects and concurrent subscribe failures merges. Before marking ready, verify the fix is included in the actual release cut; retarget the version guidance if v5.4.0 ships without it. Its scoped-isolation guarantee is not in the already merged implementation.

🔧 Changes

Overlaps Assemble the v5 reference and open release notes from harper and harper-pro; preserve this guidance if the reference assembly lands second.

✅ Verification

  • Full formatting write/check and production build passed; 426 documents processed.
  • Contract checked against core source and the passing distinct-worker HTTP expiry/reconnect scenario.
  • Author source checks and independent Claude/Composer reviews checked the subscription contracts, retry instructions, and release wording.

🤔 Merge order

The reference describes the upcoming v5.4 behavior. Stable v5.4.0 is not tagged yet; the scoped restoration paragraph must ship with its dependent core fix.

🤔 Final review scope

Four full passes covered the four-page change. Closing checks were limited to the resulting wording fixes: cleanup advice, shared lifecycle placement, and migration responses. A further full pass would repeat the same contract review; the final change adds no API behavior.

Comment generated by kAIle (GPT-6)

Release target: main — documentation for core v5.4
Related PRs: #788 overlaps (reference assembly moves the same MCP pages)
Complexity: easy

Deferred findings

Review-Coverage: authored=codex; ran=cursor-composer,claude; adjudicated=domain; declined=gemini,cursor-grok,muse; rounds=10; full=4 @ a73e21b

Review-Attention: skim ~2m (decisions: earlier-credential-expiry, blocking-reconnect-restoration, scoped-restoration-isolation) @ a73e21b

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MCP documentation and release notes to clarify how resource subscriptions behave across multiple HTTP workers, specifically detailing credential expiry preservation, reconnect restoration, and credential rotation. The review feedback suggests improving readability by splitting several long sentences containing semicolons into separate, distinct sentences to clearly isolate critical limitations and instructions.

Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/tools-and-resources.md Resolved
Comment thread release-notes/v5-lincoln/5.4.md Resolved
Comment thread release-notes/v5-lincoln/5.4.md Resolved
@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 06:15 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 06:19 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@kylebernhardy
kylebernhardy marked this pull request as ready for review November 4, 2026 06:23
@kylebernhardy
kylebernhardy requested a review from a team as a code owner November 4, 2026 06:23

@kriszyp kriszyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Reviewed with Muse

Comment thread release-notes/v5-lincoln/5.4.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/subscriptions.md Resolved
Comment thread reference/mcp/tools-and-resources.md Resolved
Comment thread release-notes/v5-lincoln/5.4.md Resolved
@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 19:27 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 19:51 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 20:01 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 20:13 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@github-actions
github-actions Bot temporarily deployed to pr-798 November 4, 2026 20:17 Inactive
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798

This preview will update automatically when you push new commits.

@kriszyp

kriszyp commented Nov 5, 2026

Copy link
Copy Markdown
Member

Heads-up: the v5 reference and the 5.4 release notes now live in the code repos (documentation#788, harper#3944, harper-pro#1237). reference/ and release-notes/v5-lincoln/5.4.md no longer exist on main here, so this PR's changes to them need to move. Thanks for your patience with the shuffle!

  • Reference pages go to docs/reference/ at the same relative path, in HarperFast/harper (in HarperFast/harper-pro for replication/, web-application-firewall/, and the Pro sections of core pages, which are _pro-*.md partials there).
  • 5.4 release notes become one fragment file per change in docs/release-notes/v5-lincoln/5.4/ of the repo the change ships in. The fragment format is in harper's docs/README.md.
  • If the code change this documents is still in an open PR, the docs can go in that same PR now; no companion PR needed.
  • Changes to other files here (learn/, fabric/, the v4 reference) stay in this repo.

— Claude Opus 5.5

Copy link
Copy Markdown
Member Author

This work now lives with its implementation in Fix scoped MCP reconnects and concurrent subscribe failures. Following main's documentation ownership change, the v5 reference edits are under Harper's docs/reference/mcp/, and the upgrade/feature notes use separate fragments under docs/release-notes/v5-lincoln/5.4/. The reviewed guidance and feedback fixes were carried over; the documentation repo assembles these sources at build time.

Closing this companion PR as superseded so it cannot reintroduce edits to generated content paths. The current site build against the migrated source passed (426 documents), and the MCP suite passed all 620 tests.

Comment generated by kAIle (GPT-6)

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🧹 Preview Cleanup

The preview deployment for this PR has been removed.

This branch was previously deployed

1 inactive deployment
pr-798 — a73e21bc Deployed Nov 4, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants