Skip to content

Restore the project .env CLI flow on the Fabric and Learn pages - #801

Merged
kriszyp merged 4 commits into
mainfrom
docs/revert-cli-dotenv-refusal
Nov 5, 2026
Merged

kriszyp merged 4 commits into
mainfrom
docs/revert-cli-dotenv-refusal

Conversation

@kriszyp

@kriszyp kriszyp commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

⊙ Problem

Revert the CLI refusal of a project .env (harper#4039) lets a project .env configure the harper CLI again, as in v5.3. Two pages here still describe the refusal from documentation#796: they tell readers to remove HARPER_CLI_TARGET from .env and say the CLI stops with an error.

💡 Solution

  • The safe-deployments guide again sets the target in the project .env, logs in with bare harper login, and copies .env into the staged deploy directory.
  • The Fabric page drops the refusal and again says harper login appends HARPER_CLI_TARGET to an existing .env.
  • Three fixes to the old text. Login skips appending when your environment sets the target. The credential warning names HARPER_CLI_USERNAME and HARPER_CLI_PASSWORD. Shipping the staged .env is called harmless only while it holds just the target.

🤔 Merge after the live reference drops the refusal

The site uses harper's docs at harper-pro main's core pointer, which today carries the refusal. Depends-on holds this PR until harper#4039 merges. Merging before harper-pro updates core to include it leaves the guide and reference in conflict. Check with node scripts/assemble-content.mjs --sources.

🔧 Changes

✅ Verification

  • Each restored claim checked against harper#4039's head 392a82d. The login prompt defaults to the .env target (bin/login.ts:22,52-56). The append is skipped when the file or environment sets HARPER_CLI_TARGET or CLI_TARGET (bin/login.ts:152-165). Every command loads .env without overriding the shell (bin/cliOperations.ts:948). Login saves last_target (bin/cliCredentials.ts:111).
  • HARPER_DOCS_PATH=<harper#4039 docs> npm run build: passes. The assembled authentication page has no refusal section, and the build logged no broken links or anchors.
  • npm run format:check: clean.
  • Not run end to end against a cluster: no disposable cluster here. The CLI behavior is v5.3's, covered by harper#4039's unit tests.

Depends-on: harper#4039

🤖 Generated by Anthropic Claude (Opus 5.5); posted via @kriszyp.

Related PRs: #796 overlaps (this reverts its changes to both pages)
Complexity: easy

Deferred findings

  • ecc7a9a3914ba23a minor documentation — learn/administration/safe-deployments-and-rollback.mdx — Learn page restores .env target flow while assembled v5 reference may still describe the 5.4 refusal until harper#4039 reaches harper-pro's — NOT FILED
Origin — the dispatch brief this PR was written from

Undo the CLI .env refusal on the learn and fabric pages

Docs pages in HarperFast/documentation still describe a CLI refusal that is being reverted.

HarperFast/harper#4039 reverts the part of HarperFast/harper#4001 that made the harper CLI refuse a project .env setting its target or credentials. A project .env can configure the CLI again, as in v5.3. harper login again appends HARPER_CLI_TARGET to an existing .env, using the URL the client connected to.

#796 documented the refusal. Its reference/ pages and release notes moved into HarperFast/harper's docs/ and are handled by #4039. Two pages stayed in this repo and need the #796 changes undone: fabric/cluster-creation-management.md and learn/administration/safe-deployments-and-rollback.mdx (restore the .env-based flow and remove "From v5.4.0, the CLI stops with an error").

Wait until HarperFast/harper#4039 is merged before opening for review; if it is closed unmerged, stop and report that.

Dispatch: task docs-harper-revert-4001 · queued by task:release-cut-main-5.4.0-beta.1 · ran by claude/opus/xhigh · worker kzyp-xps-1

Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,muse; rounds=4; full=1 @ fc3b8b6

Review-Attention: skim ~2m (decisions: env-file-target-vs-shell-export, exact-revert-vs-corrected-revert) @ fc3b8b6

kriszyp and others added 3 commits November 4, 2026 21:34
harper#4039 reverts the CLI refusal of a project .env target or
credential, so undo what documentation#796 changed on the two pages that
stayed in this repo: the safe-deployments guide again pins the target in
.env and copies it into the staged deploy directory, and the Fabric page
again says harper login appends HARPER_CLI_TARGET to an existing .env.

Two corrections beyond the revert: the append also skips when the
environment sets a target, and the credential warning names the primary
HARPER_CLI_USERNAME/HARPER_CLI_PASSWORD variables.

Dispatch-Task: docs-harper-revert-4001
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: docs-harper-revert-4001
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dispatch-Task: docs-harper-revert-4001
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kriszyp kriszyp added this to the v5.4 milestone Nov 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect changes in how the Harper CLI handles target configuration, transitioning from shell environment variables to utilizing a local .env file. It explains the automatic appending of HARPER_CLI_TARGET during login, details the loading behavior during deployment, and warns against storing sensitive credentials in .env because it is uploaded to all nodes. The review feedback recommends splitting a security warning regarding credentials and deployment uploads into separate sentences to improve readability and emphasize the warning.

@github-actions
github-actions Bot temporarily deployed to pr-801 November 5, 2026 04:48 Inactive
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-801

This preview will update automatically when you push new commits.

Dispatch-Task: docs-harper-revert-4001
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions
github-actions Bot temporarily deployed to pr-801 November 5, 2026 04:54 Inactive
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-801

This preview will update automatically when you push new commits.

@kriszyp
kriszyp marked this pull request as ready for review November 5, 2026 05:16
@kriszyp
kriszyp requested a review from a team as a code owner November 5, 2026 05:16
@kriszyp
kriszyp merged commit 489477b into main Nov 5, 2026
15 of 16 checks passed
@kriszyp
kriszyp deleted the docs/revert-cli-dotenv-refusal branch November 5, 2026 05:16
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

🧹 Preview Cleanup

The preview deployment for this PR has been removed.

This branch was previously deployed

1 inactive deployment
pr-801 — fc3b8b60 Deployed Nov 5, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant