Repository navigation
root - chore: defense - use kebab-case workflow names - #169
Conversation
The CodeQL job id is analyze. Workflow names already use kebab-case. The checklist records pull request 168 as done. The workflow name item stays open. Co-authored-by: Jared Wray <me@jaredwray.com>
The checklist names the open pull request. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the DEFENSE_IN_DEPTH.md file to mark several security checklist items as completed, specifically referencing PR #168. These items include linting workflows with zizmor, setting persist-credentials to false on checkouts, and disabling default caching in actions/setup-node for artifact-publishing workflows. There are no review comments, and we have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 639 639
Branches 151 146 -5
=========================================
Hits 639 639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
This chore changes workflow names only. No new test is required.
What kind of change does this PR introduce?
Chore. The CodeQL job uses its job id as the check name.
Summary
The CodeQL job name was
Analyze.The job id
analyzeis now the check name.Other workflow names already use kebab-case.
No job
name:field contains a space.A matrix check still shows a suffix, for example
build-test (22).GitHub adds that suffix. The YAML
name:fields have no spaces.Status
DEFENSE_IN_DEPTH.md:name:and jobname:contain no spaces → (PR root - chore: defense - use kebab-case workflow names #169 pending)Verification
Reference
defense-in-depth-nodejs § 4