Repository navigation
News 47877: Improve Timeline Panel Visual Layout - #11689
matheuszych wants to merge 1 commit into
Conversation
|
The changes unfortunately couldn’t be limited to the news module. We also had to update the Like and Notes components to make this work, so you can expect some related changes in other areas as well. @alex40724 I’d kindly ask you to review these proposed changes. |
fhelfer
left a comment
There was a problem hiding this comment.
Thank you @matheuszych,
changing the button to standard is definitely the right choice.
However the PR changes like#like from “Like” to “React” / “Reagieren”. That key is shared and must stay the label for the 👍 reaction type, not the popover trigger.
It is still used in:
- ilLikeGUI::getExpressionText() (components/ILIAS/Like/classes/class.ilLikeGUI.php, ~369) – maps TYPE_LIKE to $lng->txt("like"). Called from ilMembershipCronNotifications::parseNewsItem() (components/ILIAS/Membership/classes/Cron/class.ilMembershipCronNotifications.php, ~301) for course/group notification mails. After this change, thumbs-up reactions appear as “React” / “Reagieren” instead of “Like”.
Looks like this
Kurs "My Course": "sadfsdf" - sdfsdf
Neue Reaktionen (14)
[dummy5006], 26. Jun 2026, 12:04: Angry
[dummy5003], 26. Jun 2026, 12:04: Laugh
[dummy5002], 26. Jun 2026, 12:04: Love
[dummy5001], 26. Jun 2026, 12:04: Dislike
[dummy5000], 26. Jun 2026, 12:04: Reagieren
[dummy5005], 26. Jun 2026, 12:04: Sad
[dummy5004], 26. Jun 2026, 12:04: Astounded
- Emoji counter buttons – Button renderer sets aria-label via getSymbolLabel() → txt("like") for the like glyph (with counter).
The trigger button in getHTML() (~140) may use a new key (e.g. react / add_reaction); like should remain for the expression type.
|
Hello @fhelfer , I added a new language variable Best regards |
fhelfer
left a comment
There was a problem hiding this comment.
Thanks, @matheuszych, looks good for the changes to the Like-Component
45036a7 to
7aa757d
Compare
|
Hello @alex40724 , Best regards |
|
Hi @matheuszych Thank you a lot for contributing to ILIAS. Please answer the following questions:
Please consider the following suggestions:
Please implement the following changes:
kindly, |
7aa757d to
f8e81a2
Compare
|
Hallo @alex40724, Primarily we intended to change the behaviour of the comments inside of the news timeline but we believe it is a good idea to keep this uniform across every context. We decided to remove the message because it was causing a visual bug. After further testing with the most recent changes, it seems that said bug does not exist anymore, and thus we can keep the message. This makes it of course much easier and less invasive. I reworked some of the changes and made them much slimmer. Could you please take a quick look again? Best regards |
|
Hey @alex40724, @matheuszych adjusted the implementation according to your feedback. Some parts from the earlier review have been changed completely, so there may be some drift from the open objections. Are there still any open objections from your side? Kind regards, |
See: https://mantis.ilias.de/view.php?id=47877 News timeline items displayed Like and Notes as shy buttons with vertical dividers next to reaction counters, and the header relied on floats. That produced an uneven panel footer. Layout now uses flexbox (`ilTimelinePanelFooter`), standard buttons for Like and Notes, and no vertical dividers. The Like control label calls `txt('react')`; the missing `react` entries in `like_de.po` and `like_en.po` are added so the button no longer shows `-react-`. Notes comment labels use `notes_add_edit_comment`.
See: https://mantis.ilias.de/view.php?id=47877
The timeline panel header and footer used float-based spacing and shy
buttons with vertical dividers, which produced an uneven layout. Switched
the header to flexbox, aligned footer actions with
ilTimelinePanelFooter, promoted Like and Notes triggers to standardbuttons, removed the separators, and updated related language strings and
styles.
/cc @thojou