Repository navigation
[FIX] UI: remove unintended Prompt\IsPromptContent - #11853
Conversation
thibsy
added
php
|
For anyone who shepherds this: please only perform a review, I will handle integration myself. |
fhelfer
left a comment
fhelfer
left a comment
There was a problem hiding this comment.
Hi @thibsy,
Thanks for the change. This looks good in general.
Two methods dropped off the public Modal\RoundTrip contract with the move away from Form\Standard, but both are still implemented and used:
getSubmitLabel() is what the modal renderer uses for the submit button.
getPostURL() is what the metadata editor uses when rebuilding the modal after an error.
Please consider declaring both on the interface again.
The OER Harvester prompt usages need to be addressed here or as a follow-up PR
Kind regards, @fhelfer
The `Modal\Roundtrip` and `Dropzone\File` components inherited `Prompt\IsPromptContent` unintendedly by `Form\Standard`, which was parent class of both. To remove these components from being valid prompt content, the inheritance was changed from `Input\Container\Form\Standard` to `Input\Container\Container`. To minimise breaking changes, the `withSubmitLabel()`, `getSubmitLabel()` and `getPostURL()` methods were explicitly addedd to the `Modal\RoundTrip` instead.
1ba2e32 to
ca264c0
Compare
|
Thx @fhelfer for the review. I added these methods to the roundtrip interface explicitly. Usages of OER harvester are already taken care of by the introduction of secondary prompt contents. |
|
I'll announce the inheritance change at next JF. |
|
Hi @thibsy, thanks for providing this PR. Is this a fix for an UI issue in currently maintained ILIAS versions or an improvement of the UI component that comes with 12? I just need to know in which part of the agenda I'll gonna place it ;-) |
|
@matthiaskunkel I think we can classify this as improvement for 12. |
Hi all,
The
Modal\RoundtripandDropzone\Filecomponents inheritedPrompt\IsPromptContentunintendedly byForm\Standard, which was parent class of both.To remove these components from being valid prompt content, the inheritance was changed from
Input\Container\Form\StandardtoInput\Container\Container. To minimise breaking changes, thewithSubmitLabel()was added to theModal\RoundTripexplicitly. This path was chosen to omit thePrompt\IsPromptContentfrom being inherited, while still offering the data processing options of an input container, as I believe they were more widely used.There are four usages of
Modal\RoundTripused asPrompt\IsPromptContentinsideILIAS\MetaData\OERHarvester\ControlCenter\ControlCenterGUI. @schmitz-ilias, how would you like to proceed?Kind regards,
@thibsy