Skip to content

Bugfix: Broken setup due to Cron references in Background Tasks #12323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjansenDatabay merged 1 commit into from
Oct 28, 2026
Merged

Bugfix: Broken setup due to Cron references in Background Tasks #12323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions components/ILIAS/BackgroundTasks/classes/class.ilBackgroundTaskGarbageCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,18 @@
*********************************************************************/

use ILIAS\BackgroundTasks\Persistence;
use ILIAS\Cron\Schedule\CronJobScheduleType;
use ILIAS\Cron\CronJob;
use ILIAS\Cron\Job\JobResult;
use ILIAS\Cron\Job\Schedule\JobScheduleType;

/**
* Garbage collection for BackgroundTasks
*/
class ilBackgroundTaskGarbageCollection extends ilCronJob
class ilBackgroundTaskGarbageCollection extends CronJob
{
private ilLogger $logger;
private ilLanguage $lng;
private ilCronJobResult $result;
private JobResult $result;
private Persistence $persistence;

public function __construct()
Expand All @@ -38,7 +40,7 @@ public function __construct()
$this->lng->loadLanguageModule('background_tasks');
$this->persistence = $DIC->backgroundTasks()->persistence();

$this->result = new ilCronJobResult();
$this->result = new JobResult();
}

public function getTitle(): string
Expand Down Expand Up @@ -66,31 +68,31 @@ public function hasFlexibleSchedule(): bool
return true;
}

public function getDefaultScheduleType(): CronJobScheduleType
public function getDefaultScheduleType(): JobScheduleType
{
return CronJobScheduleType::SCHEDULE_TYPE_IN_HOURS;
return JobScheduleType::IN_HOURS;
}

public function getDefaultScheduleValue(): ?int
{
return 1;
}

public function run(): ilCronJobResult
public function run(): JobResult
{
$this->logger->debug('Starting background task garbage collector..');

try {
$this->persistence->garbageCollection();
} catch (Exception $e) {
$this->result->setStatus(ilCronJobResult::STATUS_CRASHED);
$this->result->setStatus(JobResult::STATUS_CRASHED);
$this->result->setMessage(mb_substr("Exc.: {$e->getMessage()} / {$e->getTraceAsString()}", 0, 400));
$this->logger->error("Background-Task Garbage Collection execution failed with message: {$e->getMessage()}");
$this->logger->error($e->getTraceAsString());
return $this->result;
}

$this->result->setStatus(ilCronJobResult::STATUS_OK);
$this->result->setStatus(JobResult::STATUS_OK);
return $this->result;
}
}
Loading