Repository navigation
feat: support CCL Scatter - #89
Merged
Ziminli merged 3 commits intoNov 12, 2026
Merged
Conversation
xingjiangjun
force-pushed
the
feat/ccl-scatter-followup
branch
from
November 12, 2026 07:41
3517f46 to
c4278e2
Compare
Ziminli
approved these changes
Nov 12, 2026
41 of 52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add native NCCL/MCCL
Scattersupport through the existing shared CCL framework.This PR is a follow-up to #68, originally contributed by @GordonYang1.
Changes
ncclScatter()/mcclScatter()through a shared implementation.Scatterexamples following the MPI example conventions.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A — New operator support; no comparative performance claim.
Known Issues & Future Work
Scatterrequires NCCL 2.28.3 or newer. Other compatible SDKs and RDMA/RoCE remain unverified.Test Results
Test Involved Platform
Test Involved Backend
NVIDIA A100 — NCCL 2.30.4:
Scatter, 1/2/4/8 GPUs — 5/5 PASS. Logs.Scatter, 2/8 GPUs — 2/2 PASS. Logs.MetaX C550 — MCCL 2.16.5, OpenMPI 4.1.6:
Scatter, 1/2/4/8 GPUs — 5/5 PASS. Logs.Scatter, 2/8 GPUs — 2/2 PASS. Logs.NVIDIA + MetaX — OpenMPI 4.1.6, UCX/TCP:
Scatter, 2+2/8+8 GPUs — 2/2 PASS; supplementary all-rank validation — 2/2 PASS. Logs.Native 8-GPU coverage includes counts 16 and 4096.
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General). — Existing example section-label conventions retained.CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++). — Uses existingCHECK_RT/CHECK_INFINI,ReturnStatus, and example CLI parsing; no assert-only error handling.CONTRIBUTING.md§C++).CONTRIBUTING.md§C++). — No constructors added.CONTRIBUTING.md§C++).CONTRIBUTING.md§C++). — Follows the existing exampleThreadArgslayout.CONTRIBUTING.md§C++).Python Specific (if Python files changed)
N/A — No Python files changed.
Testing
Scatter; MPI on a 2+2/8+8 NVIDIA–MetaX cluster, Native and Hybrid separately on their supported platforms.Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable. — No new backend or device.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer. — No existing operation removed or changed incompatibly; native NVIDIA support requires the version stated above.Security and Safety