Repository navigation
fix(cambricon): link TopK Softmax for 16-bit inputs - #1051
Open
baominghelly wants to merge 2 commits into
Open
baominghelly wants to merge 2 commits into
baominghelly wants to merge 2 commits into
Conversation
Instantiate the launcher with the InfiniRT storage types used by host dispatch so the FP16 and BF16 symbols resolve for every supported index type.
baominghelly
marked this pull request as ready for review
November 20, 2026 05:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopkSoftmaxUnionlauncher with InfiniRT'sFloat16andBFloat16storage types for each supported index type. Use the short names imported intoinfini::ops, as in the Cambriconfilllauncher.Motivation
The Cambricon provider introduced in #958 compiles its BANG kernel but fails to link a full native build. Host dispatch requests the InfiniRT storage types, while the BANG object emits the launcher symbols for
__halfand__bang_bfloat16. The linker reports six undefinedTopkSoftmaxUnionreferences.Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Validated the final commit in a fresh build directory on
cambricon30(MLU590-M9), withcncc 5.7.2and InfiniRTc0810cf. The original full build failed atexamples/gemm. The patched build linked the library and all examples.nm -DC --undefined-onlyfound zero unresolvedTopkSoftmaxUnionsymbols. Clang Format 21.1.8 passed on the changed file.Test Results on Supported Platforms
Benchmark / Performance Impact
N/A
Notes for Reviewers
The existing
LoadAsFloatbranches already handle both InfiniRT storage types. The revised instantiations resolve the FP16 and BF16 launchers forint32_t,uint32_t, andint64_tindices. The repository's default Cambricon CI smoke allowlist omitstopk_softmax, so the reproduction and validation used the full native configuration.