Skip to content

fix: decode query param keys - #1093

Merged
garronej merged 1 commit into
mainfrom
fix/uri-encoded-query-keys
Oct 8, 2026
Merged

garronej merged 1 commit into
mainfrom
fix/uri-encoded-query-keys

Conversation

@nicolst

@nicolst nicolst commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

We've had a user complain that they cannot link to a preconfigured service in GitHub markdown files. It seems like this is because in GH MD [ and ] are URI encoded (%5B and %5D) automatically. Onyxia only looks for literal [] and not their URI encoded versions. This is one potential fix (tested in our dev env), or one could extend the regex.. But this is a pretty easy one if you don't see any problems with it.

Summary by CodeRabbit

  • Bug Fixes
    • Helm values patch query keys are now decoded before their paths are parsed. Malformed percent-encoding may result in an error.

We've had a user complain that they cannot link to a preconfigured service in GitHub markdown files. It seems like this is because in GH MD [ and ] are URI encoded (%5B and %5D) automatically. Onyxia only looks for literal [] and not their URI encoded versions. This is one potential fix (tested in our dev env), or one could extend the regex.. But this is a pretty easy one if you don't see any problems with it.
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32e1415a-6235-4d87-a257-61a2ba1cc0a2
📥 Commits

Reviewing files that changed from the base of the PR and between 0649fd6 and c0307cd.

📒 Files selected for processing (1)
  • web/src/ui/pages/launcher/route.ts
 __________________________________
< RabbitMQ is just my side hustle. >
 ----------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@garronej
garronej merged commit 0f616fe into main Oct 8, 2026
6 of 8 checks passed
@garronej
garronej deleted the fix/uri-encoded-query-keys branch October 8, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants