Repository navigation
Conversation
For some accounts, DocuSign returns recipient view URLs such as https://apps-d.docusign.com/authenticate?code=... instead of a Signing/MTRedeem URL. DocuSign 4.3.0 rejected them, and presentCaptiveSigningWithUrl failed with "invalid captive signing url". The 4.3.0 binary only knows the signing/mtredeem/ path; 4.4.0 also knows docusign.com/authenticate, and its release notes list "Captive (embedded) signing fails to launch for certain accounts" as fixed. DSMManager.h, DSMEnvelopesManager.h and DSMNotificationCodes.h are byte-identical, and so are the setup keys the module reads. DSMErrorCodes.h only appends offline signing codes from 1074 up, so existing native.code values do not move. Packaging is unchanged: the same two vendored xcframeworks, with privacy manifests. The SDK minimum moves from iOS 12.0 to 15.0, below this module's 15.1. Verified in an Expo SDK 57 app on an iOS simulator, against a DocuSign demo account that returns apps-d.docusign.com/authenticate URLs: 4.3.0 rejected the URL, 4.4.0 opened the signing ceremony. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For some accounts, DocuSign returns recipient view URLs such as
https://apps-d.docusign.com/authenticate?code=...instead of aSigning/MTRedeemURL. With DocuSign iOS SDK 4.3.0,presentCaptiveSigningWithUrlrejects them:The 4.3.0 binary only contains the
signing/mtredeem/path. The 4.4.0 binary also containsdocusign.com/authenticate, and DocuSign's 4.4.0 release notes list "Captive (embedded) signing fails to launch for certain accounts" as fixed.Change
ios/ReactNativeDocuSign.podspec:DocuSign ~> 4.3.0to~> 4.4.0.## Next. I left the package version to you.Compatibility
DSMManager.h,DSMEnvelopesManager.handDSMNotificationCodes.hare byte-identical between 4.3.0 and 4.4.0, and so are the setup keys the module reads.DSMErrorCodes.honly appends offline signing codes from 1074 up, so existingnative.codevalues do not move.Podfile.lockneedspod update DocuSign.Testing
apps-d.docusign.com/authenticateURLs: 4.3.0 rejected the URL as above, and 4.4.0 opened the signing ceremony. The URL came fromPOST /envelopes/{envelopeId}/views/recipient, with and withoutframeAncestors/messageOrigins.npm run build,npm run lint,npm test(101 tests) andnpm run typecheck:examplespass.🤖 Generated with Claude Code