Repository navigation
Resolve flatpak findings - #231
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes address both reported Flatpak issues without identified regressions.
Review effort: Balanced
Findings: None
What changed in this PR
Resolves Flatpak upload permissions and duplicate/invalid drive listings on SteamOS.
Changes:
- Enables outbound network access for portal uploads.
- Filters Flatpak sandbox mounts and deduplicates block devices.
- Resolves writable locations before detecting batch drive models.
| File | Description |
|---|---|
jdm-dist/jdm-flatpak/net.jdiskmark.JDiskMark.yml |
Grants network access. |
jdm-core/src/main/java/jdiskmark/UtilOs.java |
Adds Flatpak-aware mount filtering. |
jdm-core/src/main/java/jdiskmark/BatchWorker.java |
Improves batch drive-model resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve upload and duplicate drive / model type listings: