Repository navigation
Conversation
No one uses this, as far as I can tell, but might as well fix it anyway. This is a breaking change. - `getEpsilon` is wrong, rather it _almost_ returns $\gamma$ - the denominator of the $\gamma$ calculation should be $Q$, not $Q^2$ - the correct `getEpsilon` also needs an energy parameter (to calculate $y$)
c-dilks
requested review from
baltzell,
raffaelladevita and
zieglerv
as code owners
November 11, 2026 16:47
baltzell
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No one uses this, as far as I can tell, but might as well fix it anyway. This is a breaking change.
getEpsilonis wrong, rather it almost returnsgetEpsilonalso needs an energy parameter (to calculate