Repository navigation
weights missing from ROOT tree generated by gen_amp_V2 #424
Description
Ilia reported that weights are not written to the ROOT treen generated by gen_amp_V2 unless the fsroot tree format is used. The reason for this appears to be in the different implementations of the data writers. The FSROOTDataWriter writes the weights by default. The ROOTDataWriter needs to have an optional argument set to "true" in order to write the weight. This line in gen_amp_V2 does not set that line.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Priority
None yet
Activity
iljatt commentedon Nov 6, 2026
Hello, Matt,
I found that the default ROOTDataWriter doesn't write a weight branch, as seen from line 24
Should then there be a reason to skip writing the branch weight in ROOTDataWriter ?
Will it be enough just to add missing arguments in gen_amp_V2, where it calls the data writer line 372 ?
mashephe commentedon Nov 8, 2026
Yes, check ROOTDataWriter.h -- I think you just need to add two extra arguments: "true" , "true" The second argument is the change from default behavior and is the one that will write the weight.
mashephe commentedon Nov 9, 2026
Fixed with #425