Repository navigation
Small Improvements to CSV converter - #428
Open
kevScheuer wants to merge 1 commit into
Open
kevScheuer wants to merge 1 commit into
kevScheuer wants to merge 1 commit into
Conversation
Bugs addressed: - The normalization integral csv sometimes printed "a+-j0.0" strings, which broke abilities to recognize it as a complex value. Now only prints "a+jb" or "a-jb" values - Only scaled production parameters were output by the FitConverter. This could be a potential source of confusion, and was unnecessary, because the scale parameters are also saved separately. The non-scaled production parameters are now returned. - Normalization integrals are now the acceptance- corrected "ampInt" ones when acceptance-corrected results are requested. - Warning suppression now also applies to the amplitude parser. QOL: - Many of the methods in FitConverter are better suited for the AmplitudeParser class, and so were moved there - Many parser functions were promoted to public and/or static so that other classes can make easy use of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs addressed:
x+-j0.0strings, which broke abilities to recognize it as a complex value. Now only printsx+jyorx-jyvaluesampIntones when acceptance-corrected results are requested.QOL: