Repository navigation
Let the GitLab sync leave out groups and projects - #53
Merged
Merged
Conversation
The GitLab sync reads every project in the acc group and its subgroups, so it suggests adding the throwaway projects in acc/scratch. A new CSV setting, GITLAB_SYNC_EXCLUDE_CSV, lists GitLab paths the sync leaves out: a group with its subgroups and projects, or a single project, matched on the project's path_with_namespace without regard to case or surrounding slashes. It defaults to acc/scratch. Existing databases get the setting from container/oracle/upgrade/2.4.0_gitlab_sync_exclude.sql; without it the sync leaves out nothing, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slominskir
approved these changes
Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The GitLab sync reads every project in the
accgroup and its subgroups, so it suggests adding the throwaway projects inacc/scratch. A new CSV setting,GITLAB_SYNC_EXCLUDE_CSV(Setup → Settings, tagSYNC), lists the GitLab paths the sync leaves out:acc/scratch), or a single project (acc/ops/demo);path_with_namespace, without regard to case or surrounding slashes;acc/scratchdoes not leave out a sibling such asacc/scratchpad;acc/scratch.Software from an excluded path that is already in the registry now shows in the sync's Remove list, like any other project the sync no longer finds.
Upgrade
Run
container/oracle/upgrade/2.4.0_gitlab_sync_exclude.sqlonce on existing databases (asSIM_OWNER); it inserts the setting. Until it runs, the sync leaves out nothing, as before. The2.4.0name assumes this ships in the next minor release; rename it if the number differs.Checks
./gradlew build(Spotless, PMD, SpotBugs, unit tests): passes. New unit tests inSyncServiceParseTest:excludedGitLabGroupsAndProjectsAreLeftOut(a group's project, a project in a subgroup with different case, a listed project, and a similarly named sibling that is kept; entries trimmed of blanks and slashes) andnoExcludeSettingExcludesNothing(no setting, no list, a project without a path)../gradlew integrationTestagainst this branch's rebuilt app: 52 tests, all pass, including the newPagesIT.settingsListTheGitLabSyncExclusions(the admin Settings page lists the setting withacc/scratch).04_settings.sql.acc/scratchpath is assumed from the group the sync reads. There is no page change beyond the new settings row.Decisions
Prepared-by: Anthropic Claude Code:claude-opus-5-5
🤖 Generated with Claude Code