Repository navigation
CRE-4921: Allow PHPUnit 9.6 and PHP 8.x - #15
Merged
Merged
Conversation
The code already runs unchanged on PHPUnit 9.6, on PHP 7.4 and 8.4. Widen the constraints so Creator can install this with PHPUnit 9.6 on 7.4 now and on 8.x later, while PHPUnit 8.5 keeps working. CI runs every PHP version from 7.3 to 8.4 against both PHPUnit majors. The lock is gone: it pinned one PHPUnit version for the whole matrix, and a library's lock isn't used by its consumers anyway. On PHPUnit 9.6, expectsCallAt() reports the at() deprecation as a test warning; at() is removed in PHPUnit 10.
rubenbarbosa30
marked this pull request as ready for review
November 6, 2026 15:11
davi-aroldi-jimdo
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jimplan.atlassian.net/browse/CRE-4921
Creator wants to move its test toolchain from PHPUnit 8.5 to 9.6, the version that runs on both PHP 7.4 and 8.x. This package pins
phpunit/phpunit: 8.*andphp: 7.3 - 8.0, which blocks that.composer.json:php: ^7.3 || ^8.0,phpunit/phpunit: ^8.5 || ^9.6. No code changes: the library already runs on PHPUnit 9.6.composer update --with phpunit/phpunit:…).composer.lockremoved and ignored: it pinned PHPUnit 8.5.29 for the whole matrix, and consumers don't use a library's lock. This also makes Bump phpunit/phpunit from 8.5.29 to 8.5.52 #14 (Dependabot, 8.5.29 → 8.5.52) unnecessary.Checked locally on PHP 7.4 and 8.4, each with PHPUnit 8.5.56 and 9.6.38: 40/40 tests pass. On 9.6, two tests of
expectsCallAt()show PHPUnit'sat()deprecation warning (exit code 0);at()is removed in PHPUnit 10.After merge: tag
2.3.0. Creator keeps2.2.0until its PHPUnit upgrade.