Repository navigation
ci: enforce the coverage floor again and raise it to 78% - #298
Merged
Merged
Conversation
The floor, badge and upload steps were gated on Go 1.23, which left the test matrix, so none of them ran: nothing enforced a floor and the README badge stayed at 66%. Gate them on 1.24 (the oldest version in the matrix) and raise the floor from 55 to 78; total is 80.8%. Refresh the Codex coverage prompt's priority list to where the uncovered statements are now. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWQw8DzwM4bQnL7mvk6Fsq
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWQw8DzwM4bQnL7mvk6Fsq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
matrix.go-version == '1.23'. The matrix is now 1.24, 1.25 and 1.26, so none of the three ran. Nothing enforced a floor, and the README badge has been stuck at 66%.go test ./... -covermode=atomic..github/codex/coverage-improvement.md.scanner/,render/,handoff/,config/andlimits/are already above 80%; the gaps are in the root package andcmd/.Check
The
Enforce coverage floorstep on the ubuntu / Go 1.24 job should print the measured total and pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01FWQw8DzwM4bQnL7mvk6Fsq