Skip to content

Fix highest coefficient normalization in Chebyshev U transforms - #273

Merged
MikaelSlevinsky merged 2 commits into
JuliaApproximation:masterfrom
vera-rubin:fix/chebyshevu-normalization
Oct 16, 2026
Merged

MikaelSlevinsky merged 2 commits into
JuliaApproximation:masterfrom
vera-rubin:fix/chebyshevu-normalization

Conversation

@vera-rubin

Copy link
Copy Markdown
Contributor

The default Chebyshev U transforms doubled the highest coefficient in the forward direction and halved it in the inverse direction. We now normalize that mode along each transformed dimension for both in-place and out-of-place calls. We added a regression for U₂ and ran the full test suite.

Fixes #272

— ChipLab

@MikaelSlevinsky

Copy link
Copy Markdown
Member

If you push a commit to bump the version, we can register right after merge

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.47%. Comparing base (fc411c0) to head (621f33b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   77.48%   77.47%   -0.01%     
==========================================
  Files          17       17              
  Lines        3233     3246      +13     
==========================================
+ Hits         2505     2515      +10     
- Misses        728      731       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MikaelSlevinsky
MikaelSlevinsky merged commit 3f1f3e1 into JuliaApproximation:master Oct 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Chebyshev U transform doubles the highest coefficient

2 participants