Repository navigation
Fix highest coefficient normalization in Chebyshev U transforms - #273
Merged
MikaelSlevinsky merged 2 commits intoOct 16, 2026
Merged
MikaelSlevinsky merged 2 commits into
MikaelSlevinsky merged 2 commits into
Conversation
Member
|
If you push a commit to bump the version, we can register right after merge |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 77.48% 77.47% -0.01%
==========================================
Files 17 17
Lines 3233 3246 +13
==========================================
+ Hits 2505 2515 +10
- Misses 728 731 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default Chebyshev U transforms doubled the highest coefficient in the forward direction and halved it in the inverse direction. We now normalize that mode along each transformed dimension for both in-place and out-of-place calls. We added a regression for U₂ and ran the full test suite.
Fixes #272
— ChipLab