Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CMAKE_INSTALL_INCLUDEDIRcontrols whereutf8proc.his installed, but the exportedutf8proc::utf8proctarget always advertises<prefix>/include. Setting the directory toheaderstherefore produces an installation that the existingtest/appconsumer cannot use.On current
master(4bfe012), this reproduces with:The last command fails because the imported target references the nonexistent
prefix/includedirectory. Both static and shared builds are affected.Changes
GNUInstallDirsbefore defining the target's include interface and use${CMAKE_INSTALL_INCLUDEDIR}inINSTALL_INTERFACEincludeand customheaderslayouts, keeping artifact names uniqueValidation
Tested on Linux with GCC 14.2.0 and CMake 3.31.6:
add_subdirectorywithUTF8PROC_INSTALL=OFFpassWindows, macOS, MinGW, and the minimum supported CMake 3.10 were not run locally.