Repository navigation
Bind netlist cluster tables by reference instead of copying them - #2510
Merged
Merged
Conversation
- `clusters_per_cell`, `cluster_by_id` and the soft connection getters return references, but `auto` copied the whole per-cell cluster table or cluster on every pin, terminal and net shape query
Collaborator
|
That's redundant with #2496, but fixes more places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places in
LayoutToNetlist, the device extractor and the soft connection code stored the result ofclusters_per_cell,cluster_by_idor the soft connection getters in anautovariable. These functions return references, soautomade a full copy of the cluster table of a cell, or of a cluster, on every call. They now use a const reference. Nothing else changes.Pin and terminal shape queries gain the most, since they copied the cluster table of the cell for every pin:
Measured on a Xeon Gold 6148 with g++ -O2. The benchmark is not part of this PR.