Repository navigation
Conversation
Contributor
Author
|
I guess github updated the ubuntu images, which there has been messaging about. Apparently, that blew up our CI. |
Merged
Contributor
Author
|
OK, we're now past the initial failure. This will probably blow up on ocaml. The order of these PR:s will be a tad messy. |
gkreitz
force-pushed
the
tweak_warnings_below_time_limit
branch
from
November 9, 2026 14:25
03526d7 to
328ebd8
Compare
Matistjati
approved these changes
Nov 11, 2026
Matistjati
left a comment
Matistjati
left a comment
Contributor
There was a problem hiding this comment.
Good change! This feels in line with the intent of time_safety_margin, and it has a much more sane default value.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make warnings for submission behavior below time limit less spammy. Problemtools did the (IMHO) theoretically correct thing, and looks at what happens from
time_limit / time_multiplier. This, however gets quite spammy as the default value in legacy is huge (5).As this is just a heuristic warning, this PR adjusts the warning to look at what happens from
time_limit / min(time_multiplier, time_safety_margin). I think that will still keep it useful in flagging submissions which are too close for comfort, while reducing warning fatigue (if your submission runs i 1.01s and the time limit is 5s, that was a pretty useless warning).As suggested by @Matistjati - thanks!