Repository navigation
Return None instead of crashing on an invalid alpha in color5 - #82
Closed
RavSinghChandan wants to merge 1 commit into
Closed
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
Member
|
There are guidelines for contributions. Please follow them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
color5.parse_color()is documented to return None for an invalid color without raising, but an invalid alpha indevice-cmyk()or in a custom color space crashes:color4._parse_alpha()returns None for an invalid alpha, whichcolor4.parse_color()checks but color5 passed straight toColor(). It is now checked the same way, so these colors give None. Valid alphas and every other color are unchanged.Added
test_color_invalid_alpha_5; all three cases raiseTypeErrorbefore the fix