[bot] Merge 26.7 to 26.10 - #318
Open
github-actions[bot] wants to merge 2 commits into
Open
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
## Rationale Tabbing past the right edge of the window in a wide EHR data-entry grid draws the cell editor over the wrong column and never scrolls the page, so the user types into a box that appears to belong to one column while the value goes to another. The LDK cell-editing plugin aligned editors with a trailing `?`, which tells Ext to clamp the editor inside the browser viewport; EHR grids grow to fit their columns and rely on the page to scroll, so the clamp pinned off-screen editors to the window edge and left the browser nothing to scroll to. With the constraint removed the editor sits on its cell and focusing it scrolls the page, so tabbing beyond the width of the screen now scrolls horizontally to follow the active cell. ## Related Pull Requests None. ## Changes - Drop the viewport constraint from the cell editor alignment in the LDK cell-editing plugin, so editors always align to their cell and the page scrolls to keep the active editor visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: 077aec7
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.10_fb_bot_merge_26.7