Fixed the private data reminder schedule and NCBI publication search failure handling - #675

Open

vagisha wants to merge 24 commits into

release26.7-SNAPSHOTfrom

26.7_fb_panoramapublic-reminder-fixes

Commits on Aug 28, 2026

Fixed Panorama Public reminder scheduling and hardened NCBI publication search
vagisha
committed
e35411c
Captured PublicationSearchTest's server error-count baseline just before the bad-key search so incidental NCBI 5xx in earlier steps don't make checkExpectedErrors flaky on dev
vagisha
committed
02022c4
Asserted enablePublicationSearch round-trips through save in PanoramaPublicBaseTest's reminder-settings helper
vagisha
committed
21a0cc3
Scoped MockNcbiPublicationSearchService matching to the decoded db/term/id query params instead of substring-scanning the whole request URL
vagisha
committed
3c4bdfd
Added unit tests for the getString retry loop (retry-then-succeed, give-up-after-MAX_HTTP_ATTEMPTS, no-retry-on-4xx); made executeGet protected so a test subclass can drive it
vagisha
committed
0c2058f

Commits on Aug 31, 2026

Protected the NCBI API key and made a failed publication search visible

vagisha
and
claude
committed
74370ce
Moved the NCBI API key coverage into its own Selenium test

vagisha
and
claude
committed
759f5d9

Commits on Sep 1, 2026

Hardened the NCBI retry loop against 429, interruption and unreadable error bodies

vagisha
and
claude
committed
2a67949
Fixed two date tests that failed on the last days of a month

vagisha
and
claude
committed
89677df
Checked the NCBI API key before the reminder job posts anything

vagisha
and
claude
committed
2bf6107
Made the retry loop's waiting overridable so tests can check the delays

vagisha
and
claude
committed
4981c02
Stopped a 429 from the API key check looking like a rejected key

vagisha
and
claude
committed
151992f

Commits on Sep 7, 2026

Addressed review findings on the NCBI publication search and reminder job

vagisha
and
claude
committed
bf13cb4

Commits on Sep 8, 2026

Reported the reminder job's status from what the run recorded, not from log levels

vagisha
and
claude
committed
f95b5e2

Commits on Sep 27, 2026

Fixed the NCBI API key settings form and retried connection resets

vagisha
and
claude
committed
77d8727
Stopped the reminder settings from requiring an encryption key

vagisha
and
claude
committed
6981aeb
Let Cancel in the pipeline UI stop the private data reminder job

vagisha
and
claude
committed
37a97f0
Addressed review findings on NCBI error handling and the reminder settings page

vagisha
and
claude
committed
34915b8
Rejected NCBI API key changes on a server with no encryption key

vagisha
and
claude
committed
303e446
Moved the NCBI HTTP request code into NcbiHttpClient

vagisha
and
claude
committed
45b4e79
Addressed code review findings on the NCBI API key and NcbiHttpClient

vagisha
and
claude
committed
abfa8b0

Commits on Oct 5, 2026

Added an NCBI check of the API key before it is saved

vagisha
and
claude
committed
3d30a1f
Changed the reminder settings test cleanup to restore settings through an API call

vagisha
and
claude
committed
6ccc96d
Added a stop to the reminder job's publication search when NCBI does not respond

vagisha
and
claude
committed
5c8af3d