Skip to content

Remove Mascot search and import support - #1081

Open
labkey-jeckels wants to merge 1 commit into
developfrom
fb_remove_mascot
Open

labkey-jeckels wants to merge 1 commit into
developfrom
fb_remove_mascot

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

Remove Mascot support from the MS2 module, which has gone unused for years.

Related Pull Requests

Changes

  • Remove the Mascot search pipeline, the Mascot server configuration and connection test, and native .dat result import, viewing, and search indexing
  • Remove the Mascot run type, so Mascot-exported pepXML now imports as an unknown search engine
  • Upgrade script permanently drops the Mascot-only file columns from ms2.Runs and deletes the stored Mascot server settings
  • Existing Mascot runs stay in the database but display as an unknown run type, without their peptide grid, Mascot scores, MS2 search listing, experiment-run link for pipeline searches, or spectra for native .dat imports
  • Saved views, reports, and queries that reference the removed Mascot tables or columns will no longer resolve
  • Remove the Mascot test and sample data
  • Drop the unused opencsv and Lombok dependencies

Tasks

  • Claude Code Review
  • Manual Testing - N/A
  • Test Automation - N/A
  • User Education @labkey-hannah @labkey-keith
    • I (Josh) don't think that anyone will care

@labkey-jeckels labkey-jeckels self-assigned this Oct 6, 2026
@labkey-jeckels
labkey-jeckels marked this pull request as ready for review October 6, 2026 04:21
@labkey-jeckels labkey-jeckels added this to the 26.11 milestone Oct 6, 2026
// Dummy score column so that Expect aligns at the same index for the score4 column with some of the other run types
new ScoreInfo(PeptidesTableInfo.DUMMY_SCORE_COLUMN_NAME, "null"),
new ScoreInfo("Expect", "expect")),
Phenyx(PhenyxRun.class,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have full support for Phenyx?!

@labkey-keith

Copy link
Copy Markdown

@labkey-hannah, one note about user education. I think we archived all of the MS2 docs after 24.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants