Repository navigation
GH Issue 1583: edit inline lookup fields don't fire onBlur - #2080
Conversation
GH Issue 1512: fetchQueries should not includeUserQueries
cnathe
left a comment
There was a problem hiding this comment.
Change looks good for the EditInlineField case (GH1583). I'll wait to approve until the changes discussed for GH1512 are made.
Also, were there any tests added for this EditInlineField case? I think there are some SM workflow job template custom field tests that could likely be updated to check this type of behavior.
I've separated work for GH1512 to a separate branch now that its scope is bigger. SMProWorkflowCustomFieldsWithTemplateTest has been updated to cover Time and Lookup field blur. |
cnathe
left a comment
There was a problem hiding this comment.
These changes look good and I verified the behavior for the lookup field and the time field type.
One note: I tested for other field types and they do retain their value in this "click to edit, don't change anything, and blur" the edit inline field. However, the integer custom field and the job start date and due date fields all do call the updateJob API in this scenario. That can probably be split out as a separate issue as it seems unrelated to these changes.
Fixed the extra updateJob api call for date/numeric field types. |
Rationale
Related Pull Requests
Changes